Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dav): Handle duplicate event reminder #41740

Merged
merged 1 commit into from
Aug 13, 2024
Merged

fix(dav): Handle duplicate event reminder #41740

merged 1 commit into from
Aug 13, 2024

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Nov 24, 2023 •
edited
Loading

Summary

Checklist

@hamza221 hamza221 added bug 3. to review Waiting for reviews feature: caldav Related to CalDAV internals labels Nov 24, 2023
@hamza221 hamza221 marked this pull request as draft November 24, 2023 16:48
@hamza221 hamza221 force-pushed the Fix/duplicate-reminders branch from 7fa6779 to 94b61e9 Compare November 27, 2023 11:16
@hamza221 hamza221 marked this pull request as ready for review November 27, 2023 11:16
@ChristophWurst ChristophWurst changed the title Fix/handle-duplicate-reminder fix(dav): Handle duplicate event reminder Nov 27, 2023
@hamza221 hamza221 force-pushed the Fix/duplicate-reminders branch from ecdd4e7 to 55317e4 Compare April 9, 2024 20:56
tcitworld
tcitworld reviewed Apr 10, 2024
View reviewed changes
Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, tests says no

tcitworld
tcitworld requested changes Apr 10, 2024
View reviewed changes
Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need the type as well.

apps/dav/lib/CalDAV/Reminder/ReminderService.php Outdated Show resolved Hide resolved
apps/dav/lib/CalDAV/Reminder/Backend.php Outdated Show resolved Hide resolved
apps/dav/lib/CalDAV/Reminder/Backend.php Outdated Show resolved Hide resolved
apps/dav/tests/unit/CalDAV/Reminder/BackendTest.php Outdated Show resolved Hide resolved
@szaimen szaimen closed this Apr 16, 2024
@szaimen szaimen deleted the Fix/duplicate-reminders branch April 16, 2024 09:18
@ChristophWurst ChristophWurst restored the Fix/duplicate-reminders branch April 16, 2024 10:31
@ChristophWurst
Copy link
Member

@szaimen wrong button?

@szaimen
Copy link
Contributor

szaimen commented Apr 16, 2024

@szaimen wrong button?

Apparently. Sorry, not sure how this happened

@susnux susnux added this to the Nextcloud 30 milestone Apr 18, 2024
@skjnldsv skjnldsv added 2. developing Work in progress stale Ticket or PR with no recent activity and removed 3. to review Waiting for reviews labels Jul 27, 2024
This was referenced Jul 30, 2024
Merged
Merged
@hamza221 hamza221 force-pushed the Fix/duplicate-reminders branch 2 times, most recently from 2df2fb3 to 83ca989 Compare August 1, 2024 15:10
@hamza221 hamza221 requested a review from tcitworld August 1, 2024 15:12
tcitworld
tcitworld approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just cs issues

apps/dav/tests/unit/CalDAV/Reminder/BackendTest.php Outdated Show resolved Hide resolved
apps/dav/tests/unit/CalDAV/Reminder/BackendTest.php Outdated Show resolved Hide resolved
This was referenced Aug 5, 2024
Merged
Merged
@hamza221 hamza221 force-pushed the Fix/duplicate-reminders branch from 83ca989 to cb6fb15 Compare August 9, 2024 09:27
@hamza221 hamza221 added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress stale Ticket or PR with no recent activity labels Aug 9, 2024
@hamza221 hamza221 force-pushed the Fix/duplicate-reminders branch from cb6fb15 to b37dfea Compare August 12, 2024 16:54
@hamza221 hamza221 enabled auto-merge August 12, 2024 16:55
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
Merged
@hamza221 hamza221 disabled auto-merge August 13, 2024 09:46
@hamza221
fix: handle-duplicate-reminder
67957e9 
Signed-off-by: hamza221 <hamzamahjoubi221@gmail.com>
@hamza221 hamza221 force-pushed the Fix/duplicate-reminders branch from b37dfea to 67957e9 Compare August 13, 2024 09:47
@hamza221 hamza221 merged commit cee227a into master Aug 13, 2024
169 checks passed
@hamza221 hamza221 deleted the Fix/duplicate-reminders branch August 13, 2024 10:33
@ChristophWurst ChristophWurst mentioned this pull request Aug 20, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcitworld tcitworld tcitworld approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@miaulalala miaulalala Awaiting requested review from miaulalala

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: caldav Related to CalDAV internals
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.

[Bug]: Deduplicate VALARM creates duplicate calendar notification
6 participants
@hamza221 @ChristophWurst @szaimen @tcitworld @susnux @skjnldsv